This repository was archived by the owner on May 31, 2025. It is now read-only.
[rospy] Improve rospy.logXXX_throttle performance#1091
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Jul 10, 2017
Merged
[rospy] Improve rospy.logXXX_throttle performance#1091dirk-thomas merged 1 commit intoros:lunar-develfrom
dirk-thomas merged 1 commit intoros:lunar-develfrom
Conversation
b79c80d to
f6a4df1
Compare
Member
|
Thank you for the improvement. @wkentaro Since you implemented this feature could you give this patch a try since the tests don't cover the actual frame information. |
Contributor
|
LGTM. It works and improves the performance. |
Member
|
Thanks for testing. |
This was referenced Jul 10, 2017
Contributor
Author
|
@wkentaro Thanks for taking your time and testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I found that the performance of
rospy.logXXX_throttlegets even worse than normalrospy.logXXXwhen the stack is rather deep such as in a subscriber callback.I've tested the following example
and got the following result.
According to the stakcoverflow,
inspect.stackis an expensive function because it gathers all the frames and their contexts.This PR changes the way to get the parent frame and improve its performance.
The final result is