Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

[roslaunch] Fix pid file removing condition#1084

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
otamachan:lunar-devel-patch
Jul 6, 2017
Merged

[roslaunch] Fix pid file removing condition#1084
dirk-thomas merged 1 commit intoros:lunar-develfrom
otamachan:lunar-devel-patch

Conversation

@otamachan
Copy link
Copy Markdown
Contributor

This patch will fix an error when roslaunch is executed with -h option. The variable options seems remained None when -h option is parsed.

$ roslaunch -h
Usage: roslaunch [options] [package] <filename> [arg_name:=value...]
       roslaunch [options] <filename> [<filename>...] [arg_name:=value...]

If <filename> is a single dash ('-'), launch XML is read from standard input.

Options:
  -h, --help            show this help message and exit
  --files               Print list files loaded by launch file, including
                        launch file itself
  --args=NODE_NAME      Print command-line arguments for node
  --nodes               Print list of node names in launch file
  --find-node=NODE_NAME
                        Find launch file that node is defined in
  -c NAME, --child=NAME
                        Run as child service 'NAME'. Required with -u
  --local               Do not launch remote nodes
  --screen              Force output of all local nodes to screen
  -u URI, --server_uri=URI
                        URI of server. Required with -c
  --run_id=RUN_ID       run_id of session. Required with -c
  --wait                wait for master to start before launching
  -p PORT, --port=PORT  master port. Only valid if master is launched
  --core                Launch core services only
  --pid=PID_FN          write the roslaunch pid to filename
  -v                    verbose printing
  --dump-params         Dump parameters of all roslaunch files to stdout
  --skip-log-check      skip check size of log folder
  --ros-args            Display command-line arguments for this launch file
  --disable-title       Disable setting of terminal title
  -w NUM_WORKERS, --numworkers=NUM_WORKERS
                        override number of worker threads. Only valid for core
                        services.
  -t TIMEOUT, --timeout=TIMEOUT
                        override the socket connection timeout (in seconds).
                        Only valid for core services.
Traceback (most recent call last):
  File "/home/tamaki/work/ros_comm/install/bin/roslaunch", line 35, in <module>
    roslaunch.main()
  File "/home/tamaki/work/ros_comm/install/lib/python2.7/dist-packages/roslaunch/__init__.py", line 327, in main
    if options.pid_fn:
AttributeError: 'NoneType' object has no attribute 'pid_fn'

@dirk-thomas
Copy link
Copy Markdown
Member

Thank you for the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants