This repository was archived by the owner on May 31, 2025. It is now read-only.
Removed "ROS time moved backwards" log message#1027
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Apr 20, 2017
Merged
Removed "ROS time moved backwards" log message#1027dirk-thomas merged 1 commit intoros:lunar-develfrom
dirk-thomas merged 1 commit intoros:lunar-develfrom
Conversation
The log message doesn't make sense IMO, because there is still the exception being thrown. So the user can either catch it (and then he knows best whether it is an error or not), or he'll not catch it, and then he'll see the message printed in the stack trace. This is a followup of comment ros#492 (comment) . My use-case: I have a ROS node running alongside Gazebo, and resetting Gazebo always prints this error to the log, even if it is no error for me, since I expect the time to be restarted.
Member
|
Thank you for creating the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log message doesn't make sense IMO, because there is still the exception being thrown.
So the user can either catch it (and then he knows best whether it is an error or not), or he'll not catch it, and then he'll see the message printed in the stack trace.
This is a followup of comment #492 (comment) .
My use-case: I have a ROS node running alongside Gazebo, and resetting Gazebo always prints this error to the log, even if it is no error for me, since I expect the time to be restarted.