This repository was archived by the owner on May 31, 2025. It is now read-only.
This repository was archived by the owner on May 31, 2025. It is now read-only.
Non-virtual destructors in ros::console #729
Description
When compiling our codebase against ros::console with the warnings turned all the way up, we get these warnings:
In file included from /opt/ros/indigo/include/ros/ros.h:40:0,
from
... < removed private file names > ...
/opt/ros/indigo/include/ros/console.h:99:7: warning: ‘class ros::console::LogAppender’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
class LogAppender
^
/opt/ros/indigo/include/ros/console.h:109:8: warning: ‘struct ros::console::Token’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
struct Token