Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Allow custom classname, testcase name in test_xx_junit_xml.#119

Merged
dirk-thomas merged 3 commits intoros:kinetic-develfrom
mikepurvis:patch-1
Sep 16, 2016
Merged

Allow custom classname, testcase name in test_xx_junit_xml.#119
dirk-thomas merged 3 commits intoros:kinetic-develfrom
mikepurvis:patch-1

Conversation

@mikepurvis
Copy link
Copy Markdown
Member

@mikepurvis mikepurvis commented Sep 9, 2016

With the default value of "Results", tests which use this code (like the roslaunch check) get a very unhelpful description in the Jenkins layout:

screen shot 2016-09-08 at 10 19 35 pm

By specifying the classname as roslaunch.RoslaunchCheck and the case name as, eg test_my_pkg_check_launch, it would show as originating from the roslaunch package, and be much more identifiable as to what it is checking (similar to rostests being grouped under rostest.runner).

This is a no-function change that is just to enable this improved behaviour in the roslaunch check.

@dirk-thomas

@mikepurvis mikepurvis changed the title Allow custom classname in test_xx_junit_xml. Allow custom classname, testcase name in test_xx_junit_xml. Sep 9, 2016
@mikepurvis
Copy link
Copy Markdown
Member Author

There'd be an argument to be made here for test_name, class_name, testcase_name, but I'm easy going on it— would like to get this merged one way or another.

@dirk-thomas
Copy link
Copy Markdown
Member

Yes, class_name and testcase_name would be more readable imo.

Can you please create the PR against ros_comm using these new keyword arguments. Are there any other cases which you have in mind which could be updated to use these?

classname -> class_name
testcasename -> testcase_name
@mikepurvis
Copy link
Copy Markdown
Member Author

mikepurvis commented Sep 15, 2016

Update names. Two additional thoughts:

Will supply PR to ros_comm for roslaunch-check shortly.

@dirk-thomas
Copy link
Copy Markdown
Member

Would we consider adding the option to attach stdout to non-failing test?

Sounds good to me. Can be helpful to know what was happening.

Should the <system-out/> element by moved inside <testcase/>?

As long as it is compliant which how it is being parsed, how Jenkins interprets the result and we have the output on a per-test level that sounds good to me too.

@mikepurvis
Copy link
Copy Markdown
Member Author

I think this is good to go now. Example outputs and Jenkins screencaps in ros/ros_comm#897.

@dirk-thomas
Copy link
Copy Markdown
Member

Based on you comment (ros/ros_comm#897 (comment)) and some testing (afaik Jenkins won't show any system-out if the test passed and the location of the system-out in the case of the failing test doesn't make a difference it is shown either way) can you please remove the stdout related changes from the PR for now (basically the last commit)?

@mikepurvis
Copy link
Copy Markdown
Member Author

I confirm that Jenkins doesn't show stdout on success. Lame.

I've withdrawn that commit.

@dirk-thomas
Copy link
Copy Markdown
Member

Thanks for the patch and iterating on it.

@dirk-thomas dirk-thomas merged commit e49604d into ros:kinetic-devel Sep 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants