Allow custom classname, testcase name in test_xx_junit_xml.#119
Allow custom classname, testcase name in test_xx_junit_xml.#119dirk-thomas merged 3 commits intoros:kinetic-develfrom
Conversation
|
There'd be an argument to be made here for |
|
Yes, Can you please create the PR against |
classname -> class_name testcasename -> testcase_name
|
Update names. Two additional thoughts:
Will supply PR to ros_comm for roslaunch-check shortly. |
Sounds good to me. Can be helpful to know what was happening.
As long as it is compliant which how it is being parsed, how Jenkins interprets the result and we have the output on a per-test level that sounds good to me too. |
|
I think this is good to go now. Example outputs and Jenkins screencaps in ros/ros_comm#897. |
|
Based on you comment (ros/ros_comm#897 (comment)) and some testing (afaik Jenkins won't show any |
|
I confirm that Jenkins doesn't show stdout on success. Lame. I've withdrawn that commit. |
|
Thanks for the patch and iterating on it. |
With the default value of "Results", tests which use this code (like the roslaunch check) get a very unhelpful description in the Jenkins layout:
By specifying the classname as
roslaunch.RoslaunchCheckand the case name as, egtest_my_pkg_check_launch, it would show as originating from the roslaunch package, and be much more identifiable as to what it is checking (similar to rostests being grouped underrostest.runner).This is a no-function change that is just to enable this improved behaviour in the roslaunch check.
@dirk-thomas