Merged
Conversation
tfoote
approved these changes
Oct 4, 2017
Member
tfoote
left a comment
There was a problem hiding this comment.
+1 it looks like this was something that Mirza was working on at some point but it never got polished. https://github.com/ros/pluginlib/commits/cf1a7eb5a9a8bb3764c09ce20ac0ab7b5b7e1e4f/src/plugin_tool.cpp
mikaelarguedas
approved these changes
Oct 6, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm, if we can't find any mention of it anywhere I'm in favor of removing it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unable to find any reference to this tool in any documentation, wiki pages, tutorials, or launch files. I believe it was a tool used long ago, but is now unused.
It uses similar arguments to the deprecated pluginlib macros. Some of the utilities it provides might be useful, but I think it would be better integrated into some command line tools in a separate package.
However, some of the functionality is scary, especially
generateAndLoadTypedPluginInterfacewhich invokes gcc directly to then dlopen a just in time built shared library...If anyone is using the tool we could restore it pretty easily, but I think we should remove it until someone needs it.