Skip to content

Remove deprecated boost functions (fix build error on Rolling)#199

Merged
sloretz merged 1 commit intoros2from
sloretz/remove_boost_functions
Aug 5, 2020
Merged

Remove deprecated boost functions (fix build error on Rolling)#199
sloretz merged 1 commit intoros2from
sloretz/remove_boost_functions

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Aug 5, 2020 •
edited
Loading

This PR Removes PLUGINLIB__DISABLE_BOOST_FUNCTIONS and the deprecated functions it wraps.
This should fix this downstream PR job failure in the ros2/urdf repo: http://build.ros2.org/job/Rpr__urdf__ubuntu_focal_amd64/4 .

--- stderr: urdf
In file included from /tmp/ws/src/urdf/urdf/src/model.cpp:39:
/opt/ros/rolling/include/pluginlib/class_loader.hpp:55:10: fatal error: boost/shared_ptr.hpp: No such file or directory
   55 | #include <boost/shared_ptr.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

The cause appears to be PLUGINLIB__DISABLE_BOOST_FUNCTIONS not being defined by default, meaning class_loader.hpp tries to include a boost header by default. However, pluginlib neither exports boost as a dependency in its CMakeLists.txt nor declares it in its package.xml. Since the deprecation appears to have been added in 2017 I think it's fair to remove it.

244f065#diff-ca2b6071ef290a8731c40a238f8e40a8R41

@sloretz
Remove deprecated boost functions
9029357 
Removes PLUGINLIB__DISABLE_BOOST_FUNCTIONS
Fixes downstream missing include with rolling distro

Signed-off-by: Shane Loretz<sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug label Aug 5, 2020
@sloretz sloretz self-assigned this Aug 5, 2020
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Aug 5, 2020

CI ( build: --packages-above-and-dependencies pluginlib test: --packages-select pluginlib )

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz mentioned this pull request Aug 5, 2020
Merged
wjwwood
wjwwood approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think this must have been broken at some point. I can't find where though. It should have been part of the extras or something.

@sloretz sloretz merged commit b076db7 into ros2 Aug 5, 2020
@sloretz sloretz deleted the sloretz/remove_boost_functions branch August 5, 2020 20:11
@Karsten1987 Karsten1987 mentioned this pull request Oct 5, 2020
Closed
4 tasks
@destogl destogl mentioned this pull request Oct 6, 2020
Closed
@devrite devrite mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@sloretz sloretz

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @wjwwood