[ros2] Cast pointers to void * when using %p by sloretz · Pull Request #152 · ros/pluginlib

sloretz · 2019-04-30T23:28:31Z

I'm seeing a new build failure in rviz_common due to it using -Werror=format. The compiler is complaining about using %p with a pointer type that is not a void *. I don't know what change is responsible. This PR fixes it by adding a cast.

Build output without this PR

--- stderr: rviz_common                                         
In file included from /home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:71:0,
                 from /home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/class_loader.hpp:370,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:42,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/./display_factory.hpp:38,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/display_factory.cpp:31:
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp: In instantiation of ‘pluginlib::ClassLoader<T>::ClassLoader(std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::vector<std::__cxx11::basic_string<char> >) [with T = rviz_common::Display; std::__cxx11::string = std::__cxx11::basic_string<char>]’:
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:69:21:   required from ‘rviz_common::PluginlibFactory<Type>::PluginlibFactory(const QString&, const QString&) [with Type = rviz_common::Display]’
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/display_factory.cpp:50:66:   required from here
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Display>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:103:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader", "Creating ClassLoader, base = %s, address = %p",
   ^~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Display>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:116:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader",
   ^~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp: In instantiation of ‘pluginlib::ClassLoader<T>::~ClassLoader() [with T = rviz_common::Display]’:
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:75:5:   required from ‘rviz_common::PluginlibFactory<Type>::~PluginlibFactory() [with Type = rviz_common::Display]’
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/display_factory.cpp:50:66:   required from here
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Display>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:125:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader",
   ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:71:0,
                 from /home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/class_loader.hpp:370,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:42,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/./panel_factory.hpp:35,
                 from /home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/panel_factory.cpp:32:
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp: In instantiation of ‘pluginlib::ClassLoader<T>::ClassLoader(std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::vector<std::__cxx11::basic_string<char> >) [with T = rviz_common::Panel; std::__cxx11::string = std::__cxx11::basic_string<char>]’:
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:69:21:   required from ‘rviz_common::PluginlibFactory<Type>::PluginlibFactory(const QString&, const QString&) [with Type = rviz_common::Panel]’
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/panel_factory.cpp:60:62:   required from here
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Panel>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:103:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader", "Creating ClassLoader, base = %s, address = %p",
   ^~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Panel>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:116:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader",
   ^~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp: In instantiation of ‘pluginlib::ClassLoader<T>::~ClassLoader() [with T = rviz_common::Panel]’:
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/include/rviz_common/factory/pluginlib_factory.hpp:75:5:   required from ‘rviz_common::PluginlibFactory<Type>::~PluginlibFactory() [with Type = rviz_common::Panel]’
/home/sloretz/ws/ros2/src/ros2/rviz/rviz_common/src/rviz_common/panel_factory.cpp:60:62:   required from here
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:72:18: error: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘pluginlib::ClassLoader<rviz_common::Panel>*’ [-Werror=format=]
       rcutils_log(&__rcutils_logging_location, severity, name, __VA_ARGS__); \
       ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/rcutils/include/rcutils/logging_macros.h:253:3: note: in expansion of macro ‘RCUTILS_LOG_COND_NAMED’
   RCUTILS_LOG_COND_NAMED( \
   ^~~~~~~~~~~~~~~~~~~~~~
/home/sloretz/ws/ros2/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:125:3: note: in expansion of macro ‘RCUTILS_LOG_DEBUG_NAMED’
   RCUTILS_LOG_DEBUG_NAMED("pluginlib.ClassLoader",
   ^~~~~~~~~~~~~~~~~~~~~~~
cc1plus: error: unrecognized command line option ‘-Wno-gnu-zero-variadic-macro-arguments’ [-Werror]
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/rviz_common.dir/src/rviz_common/display_factory.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1plus: error: unrecognized command line option ‘-Wno-gnu-zero-variadic-macro-arguments’ [-Werror]
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/rviz_common.dir/src/rviz_common/panel_factory.cpp.o] Error 1
make[1]: *** [CMakeFiles/rviz_common.dir/all] Error 2
make: *** [all] Error 2

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

nuclearsandwich · 2019-05-01T13:42:14Z

I don't know what change is responsible. This PR fixes it by adding a cast.

With ros2/rcutils#154 warnings are emitted for "dangerous patterns" in format strings.

nuclearsandwich · 2019-05-01T13:44:48Z

Linux
Linux-aarch64
macOS
Windows

Cast pointers to void * when using %p

4f35a47

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

sloretz added the in review label Apr 30, 2019

dirk-thomas mentioned this pull request May 1, 2019

Fix format string warnings. #153

Closed

nuclearsandwich approved these changes May 1, 2019

View reviewed changes

dirk-thomas mentioned this pull request May 1, 2019

Use GCC extension for printf-like functions ros2/rcutils#154

Merged

clalancette approved these changes May 1, 2019

View reviewed changes

nuclearsandwich merged commit 816b41d into ros:ros2 May 1, 2019

sloretz deleted the cast_to_void_ptr_log branch May 1, 2019 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ros2] Cast pointers to void * when using %p#152

[ros2] Cast pointers to void * when using %p#152
nuclearsandwich merged 1 commit intoros:ros2from
sloretz:cast_to_void_ptr_log

sloretz commented Apr 30, 2019

Uh oh!

nuclearsandwich commented May 1, 2019

Uh oh!

nuclearsandwich commented May 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sloretz commented Apr 30, 2019

Uh oh!

nuclearsandwich commented May 1, 2019

Uh oh!

nuclearsandwich commented May 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants