Skip to content

export rcutils#120

Merged
mikaelarguedas merged 1 commit intoros:ros2from
Karsten1987:export_rcutils
Jul 18, 2018
Merged

export rcutils#120
mikaelarguedas merged 1 commit intoros:ros2from
Karsten1987:export_rcutils

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

@Karsten1987 Karsten1987 commented Jul 18, 2018

ran into issues when building in overlay:

In file included from /Users/karsten/workspace/osrf/ros2_full/install/pluginlib/include/pluginlib/class_loader.hpp:357:
/Users/karsten/workspace/osrf/ros2_full/install/pluginlib/include/pluginlib/./class_loader_imp.hpp:55:10: fatal error: 'rcutils/logging_macros.h' file not found
#include "rcutils/logging_macros.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

When applying this patch (exporting rcutils as a dependency), this problem is resolved.

mikaelarguedas
mikaelarguedas approved these changes Jul 18, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@mikaelarguedas mikaelarguedas merged commit dfe3824 into ros:ros2 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Karsten1987 @mikaelarguedas