Do not subscribe /clock from nodelet load#120
Conversation
|
@ros-pull-request-builder retest this please |
|
Hmm, maybe that was too fast and we actually need to wait for ros_comm release? |
|
The tests in this PR have passed after the required changes in ros_comm have been merged. This is now ready for review. |
|
@sloretz it would be great to have this PR in the larger ros_comm test you called for. Could you please have a look at it? |
sloretz
left a comment
There was a problem hiding this comment.
LGTM! @mjcarroll how does this look to you?
|
Thanks! Do you intend to make a release of nodelet_core in the period when ros_comm 1.17 is being tested? |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/preparing-for-noetic-sync-2024-10-31/40332/5 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/preparing-for-noetic-sync-2024-12-05/40942/2 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/new-packages-for-noetic-2024-12-06/40995/2 |
Depends on ros/ros_comm#2342 .
See discussion in https://robotics.stackexchange.com/questions/96165/nodelet-load-process-does-message-deserialization .
When running in
nodelet loadmode, the node doesn't really do anything that would require sim time. It should only run the bond, one service call and nothing else. This PR makes sure that it is the case even if/use_sim_timeis set to true.