Conversation
|
First Windows CI attempt: |
|
This time with the header actually committed: |
|
I do believe you have to "activate" the symbol export within your |
|
You mean that the preprocessor couldn't automatically figure out that that was my intent and just insert that definition for me? 😉 Here's the next attempt: |
…ng LinearMath library
tf2/include/tf2/LinearMath/MinMax.h
Outdated
|
|
||
| template <class T> | ||
| TF2SIMD_FORCE_INLINE const T& tf2Min(const T& a, const T& b) | ||
| TF2_PUBLIC TF2SIMD_FORCE_INLINE const T& tf2Min(const T& a, const T& b) |
There was a problem hiding this comment.
You shouldn't need to export template symbols. Templates are getting evaluated on caller side, meaning they are always in the according compilation unit.
There was a problem hiding this comment.
Also, Inline function are meant to be not exported.
There was a problem hiding this comment.
Ah, that makes sense. Clearly I'm in unfamiliar territory here. So I should remove that declaration from all the template functions? Anywhere else?
There was a problem hiding this comment.
I was reading about exporting and inline here:
https://msdn.microsoft.com/en-us/library/xa0d9ste.aspx
So they can be exported, but it's not clear to me whether they should or shouldn't be.
Looks like |
|
I thought I opened a PR with tf2_ros against your branch. Did you see it? |
|
Sorry, I hadn't noticed that. Thanks! |
|
It builds! Now we need to resolve compiler warnings: http://ci.ros2.org/job/ci_windows/2400/warnings41Result/new/ |
…witched from marking classes as public to marking the internal methods and static members. Let's see if this works.
|
it looks to me as if the builds finally succeed. The build failure comes from two failing tests which are unrelated. |
|
Thanks for the all the help, @Karsten1987 ! |
Redo of #203, where I did something wrong with git that made the ci job no longer work.