This repository was archived by the owner on May 31, 2025. It is now read-only.
Merged
Conversation
gerkey
reviewed
Mar 1, 2017
| @@ -52,6 +52,8 @@ class StaticTransformBroadcaster{ | |||
| /** \brief Constructor (needs a ros::Node reference) */ | |||
| StaticTransformBroadcaster(); | |||
There was a problem hiding this comment.
I think that this constructor prototype should be removed (or else implemented with internal creation of a node, but I think that it's clearer to force the user to pass in a node as is done with the other constructor).
Collaborator
Author
There was a problem hiding this comment.
Agreed. Should have been removed.
Updated the PR.
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you don't mind, I opened a PR against your PR for adding my changes as well.