This repository was archived by the owner on May 31, 2025. It is now read-only.
Adapt to new xmlrpcpp header location#145
Closed
mxsrc wants to merge 1 commit intoros:melodic-develfrom
Closed
Conversation
Member
|
Thanks for the patch. We can't merge this immediately as the ros_comm change has not been backported to indigo. We will either need to fork development or hold this until ros_comm backports that change to indigo. Since this the backwards compatibility has been added, I'll plan to hold this PR for now. |
Member
|
@ros-pull-request-builder retest this please |
Member
|
@ros-pull-request-builder retest this please |
Member
|
Merged in #164 to melodic-devel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144, the locations of the xmlrpcpp headers changed in ros/ros_comm@93b64b8, in ros/ros_comm@838e824 compability to the old locations was restored but this is possibly removed in the future.