Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fix exception handling on Hurd#89

Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom
jspricke:fix_hurd
Sep 30, 2017
Merged

Fix exception handling on Hurd#89
dirk-thomas merged 1 commit intoros:kinetic-develfrom
jspricke:fix_hurd

Conversation

@jspricke
Copy link
Copy Markdown
Member

Hurd uses a different errno, so testing for the string as well.

@mikaelarguedas
Copy link
Copy Markdown
Member

Thanks @jspricke for catching this.
Would it be more futureproof to change the check to compare to errno.EEXIST rather than the hardcoded 17 error code that is apparently not the value returned by all systems?

Hurd uses a different errno for example.
@jspricke
Copy link
Copy Markdown
Member Author

Much better idea, thx :).

@mikaelarguedas
Copy link
Copy Markdown
Member

👍 looks good to me, waiting for @dirk-thomas' approval before merging

@dirk-thomas
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants