Merged
Conversation
added 5 commits
June 2, 2022 10:58
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
clalancette
requested changes
Jun 2, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've done a particular review and left some things to consider inline. I'll do a more thorough review tomorrow.
Besides those things, I think we can also make some of the getters (like getTopic) const methods, as well as the isBroken method.
added 2 commits
June 6, 2022 10:50
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Also switch to rclcpp::Duration internally Signed-off-by: Michael Carroll <michael@openrobotics.org>
clalancette
requested changes
Jun 10, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've left a few more comments. This is definitely getting closer; this feels a lot more robust now.
added 2 commits
June 13, 2022 10:20
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Merged
clalancette
requested changes
Jun 13, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
One more fix (for what I think is a bug), and I think this is good to go.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
clalancette
approved these changes
Jun 13, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Thanks for all of the iteration here. I think this leaves the code in much better shape.
This was referenced Jun 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #76
Split out into multiple commits for easier reviews: