Use SteadyTime and SteadyTimer for bond timeouts#18
Use SteadyTime and SteadyTimer for bond timeouts#18mikaelarguedas merged 3 commits intoros:lunar-develfrom
Conversation
wjwwood
left a comment
There was a problem hiding this comment.
These changes lgtm, but it might require that this repository create a new branch for lunar, if the upstream API addition only gets merged there. It would need to be backported to all supported ROS distributions to avoid any branching in this repository.
It would also be possible to use the preprocessor to conditionally use SteadyTimer when it's available from roscpp, but that's up to @mikaelarguedas.
7799b59 to
0fa28b5
Compare
|
@flixr I merged some cosmetics fixups on master so I took the liberty of rebasing this branch. Thanks for providing a fix for this! That's a bug that has certainly been impacting many users |
mikaelarguedas
left a comment
There was a problem hiding this comment.
LGTM, waiting on approval on ros/ros_comm#1014 and ros/roscpp_core#57 to decide if this can me merged as is or need a distro specific segregation (preprocessor or branching out)
|
@mikaelarguedas to either branch out or ifdef to use the new timer only on Lunar |
0fa28b5 to
bff1b74
Compare
|
ros/ros_comm#1014 and ros/roscpp_core#57 have been merged so I'm going to merge this for lunar. thanks @flixr for the valuable contribution, that's a great improvement! |
bff1b74 to
8cad7d6
Compare
Fixes #16
Depends on ros/roscpp_core#57 and ros/ros_comm#1014
Tested and working on Ubuntu14.04/Indigo.