Skip to content

Re-add project_root support in alias command #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swalkinshaw merged 1 commit into from
Jul 15, 2024
Merged

Re-add project_root support in alias command #447

swalkinshaw merged 1 commit into from
Jul 15, 2024

Conversation

@swalkinshaw
Copy link
Member

@swalkinshaw swalkinshaw commented Jul 15, 2024 •
edited
Loading

Fixes #446

@codepuncher @andronocean this looks correct?

With project_root set:

"@development":
  ssh: "example.test"
  path: "/www/examplecom_123/public/current/web/wp"
"@production":
  path: "/www/examplecom_123/public/current/web/wp"
"@staging":
  path: "/www/examplecom_123/public/current/web/wp"

Without project_root set:

"@development":
  ssh: "example.test"
  path: "/srv/www/example.com/current/web/wp"
"@production":
  path: "/srv/www/example.com/current/web/wp"
"@staging":
  path: "/srv/www/example.com/current/web/wp"

@swalkinshaw swalkinshaw force-pushed the alias-cmd-readd-project-root-support branch from 179e975 to 5f8a0f2 Compare July 15, 2024 03:04
@codepuncher
Copy link
Contributor

codepuncher commented Jul 15, 2024

For some reason, this is removing the ssh key from aliases on any project I try this on!
path seems fine though

@swalkinshaw swalkinshaw force-pushed the alias-cmd-readd-project-root-support branch from 5f8a0f2 to 883f0cb Compare July 15, 2024 12:15
@swalkinshaw
Copy link
Member Author

swalkinshaw commented Jul 15, 2024

Oops, restored that

@codepuncher
Copy link
Contributor

codepuncher commented Jul 15, 2024

Perfect! Works fine for me. Thanks!

@swalkinshaw swalkinshaw merged commit 8b6976b into master Jul 15, 2024
@swalkinshaw swalkinshaw deleted the alias-cmd-readd-project-root-support branch July 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

trellis alias generates wrong path for a site on Kinsta

3 participants

@swalkinshaw @codepuncher