ValidatePortSpec should allow duplicate children#133
Merged
AkihiroSuda merged 1 commit intorootless-containers:masterfrom Mar 30, 2020
Merged
ValidatePortSpec should allow duplicate children#133AkihiroSuda merged 1 commit intorootless-containers:masterfrom
AkihiroSuda merged 1 commit intorootless-containers:masterfrom
Conversation
Previously, any duplicate child port would cause a validation failure, even if the implementation passed. This commit adjusts the port validation to handle duplicate child ports. This commit also adds an extensive test to ValidatePortSpec, which has pretty significant logic. Adds github.com/stretchr/testify/assert as a direct dependency, previously it was indirect. Resolves rootless-containers#132 Authored-by: Tyler Ramer <tyaramer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any duplicate child port would cause a validation failure,
even if the implementation passed. This commit adjusts the port
validation to handle duplicate child ports.
This commit also adds an extensive test to ValidatePortSpec, which has
pretty significant logic.
Adds github.com/stretchr/testify/assert as a direct dependency,
previously it was indirect.
Resolves #132
Authored-by: Tyler Ramer tyaramer@gmail.com