backend to create all the respective objects and relations on order start#116
Merged
Conversation
- defensive against undefined agent or profile - pure functional component - uses hyperscript
…igration to fix assigneeId column on taskPlans table
|
|
||
| } | ||
|
|
||
| Profile.propTypes = { |
There was a problem hiding this comment.
@gregorykan whats the thinking around proptypes? are we not going to use them at all?
and @ahdinosaur I am still curious and keen on an implementation of types on the apis of modules. Is the thinking that components shouldn't have a type api?
Member
There was a problem hiding this comment.
i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.
ahdinosaur
approved these changes
Jul 26, 2017
|
|
||
| } | ||
|
|
||
| Profile.propTypes = { |
Member
There was a problem hiding this comment.
i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.