Skip to content

[RF] RooFit speed improvements#9412

Merged
guitargeek merged 3 commits into
root-project:masterfrom
hageboeck:RFHackathon_forPR2
Dec 11, 2021
Merged

[RF] RooFit speed improvements#9412
guitargeek merged 3 commits into
root-project:masterfrom
hageboeck:RFHackathon_forPR2

Conversation

@hageboeck

@hageboeck hageboeck commented Dec 10, 2021

Copy link
Copy Markdown
Member
  • Remove dynamic_cast for cross casts in a multiple inheritance setting
  • Reduce the size of datasets by removing observables that are not in use.

@hageboeck hageboeck requested a review from guitargeek December 10, 2021 17:03
@hageboeck hageboeck self-assigned this Dec 10, 2021
@hageboeck hageboeck requested a review from lmoneta as a code owner December 10, 2021 17:03
@phsft-bot

phsft-bot commented Dec 10, 2021

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@hageboeck

hageboeck commented Dec 10, 2021

Copy link
Copy Markdown
Member Author

@gartrog Here is your contribution!

@hageboeck hageboeck mentioned this pull request Dec 10, 2021
Closed
@phsft-bot

phsft-bot commented Dec 10, 2021

Copy link
Copy Markdown

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot

phsft-bot commented Dec 10, 2021

Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot

phsft-bot commented Dec 10, 2021

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@hageboeck hageboeck added this to the 6.26/00 milestone Dec 10, 2021
@phsft-bot

phsft-bot commented Dec 11, 2021

Copy link
Copy Markdown

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot

phsft-bot commented Dec 11, 2021

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Dec 11, 2021

Copy link
Copy Markdown

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

guitargeek
guitargeek approved these changes Dec 11, 2021
View reviewed changes

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I went over all the commits and they make sense to me!

@guitargeek guitargeek merged commit 5736fd2 into root-project:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guitargeek guitargeek guitargeek approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta

Assignees

@hageboeck hageboeck

Labels

in:RooFit

Projects

None yet

Milestone

6.26/00

Development

Successfully merging this pull request may close these issues.

4 participants

@hageboeck @phsft-bot @guitargeek @gartrog