[RF] Fix RooAddPdf::fixCoefRange cache issue with createIntegral#10995
Merged
Conversation
When the normalization range for coefficient determination of a RooAddPdf is changed, the AddPdf's projection cache needs to be reset, just like it is already done in `RooAddPdf::fixCoefNormalization`. Otherwise, there will be problems in the pdf evaluation and integration because the projection cache is invalid. A unit test based on the GitHub issue that reported this problem is also implemented. Closes root-project#10988.
It should be avoided to have RooAbsArgs with the same object name as part of the same computation graph. This has happened in RooAddPdf when using internally defined recursive coefficients, which is changed with this commit.
|
Starting build on |
lmoneta
approved these changes
Jul 20, 2022
lmoneta
left a comment
Member
There was a problem hiding this comment.
LGTM!
Thank you for the fix and nice you have included also a test !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the normalization range for coefficient determination of a
RooAddPdf is changed, the AddPdf's projection cache needs to be reset,
just like it is already done in
RooAddPdf::fixCoefNormalization.Otherwise, there will be problems in the pdf evaluation and integration
because the projection cache is invalid.
A unit test based on the GitHub issue that reported this problem is also
implemented.
Closes #10988.
Furthermore, another potential RooAddPdf problem is fixed, where several instances of RooRecursiveFraction were created with the same name (which could become problematic for example when using the new BatchMode).