Merged
Conversation
…etcdf when writing out netcdf files, remove some pytest.mark.xfail warnings
Pull Request Test Coverage Report for Build 15883479025Details
💛 - Coveralls |
cehbrecht
approved these changes
Jun 24, 2025
Collaborator
|
@Zeitsperre does regridding work now with the latest xesmf/xarray version? |
Collaborator
Author
|
@cehbrecht As of release 2025.6, yes, everything should work properly. I've removed a bunch of the skip markers and everything seems to be working as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
What kind of change does this PR introduce?:
xarraypin for compatiblexesmfpandasversionMakefileto work better withtoxopsoutputspytest.mark.xfailmarkersDoes this PR introduce a breaking change?:
Somewhat. This PR adds a default output engine for
nc/netcdffiles (h5netcdf). This works better for most cases (i.e. better thread safety), except for instances where the metadata contains badly-encoded strings.Other information:
pydata/xarray#7794
pydata/xarray#8821