Improve gc#3845
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the garbage collection system by adding configurable RocksDB performance options, introducing a marker strategy selection mechanism, and refactoring child node extraction logic for better maintainability.
- Adds three new RocksDB configuration options:
compaction_readahead_size,allow_mmap_reads, andadvise_random_on_open - Introduces a marker strategy enum (Atomic vs Locked) with command-line configuration support
- Refactors node child extraction into a unified
extract_child_nodesfunction with comprehensive test coverage
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| moveos/raw-store/src/rocks/mod.rs | Adds RocksDB configuration storage and applies new performance options (compaction readahead, mmap, advise random) |
| moveos/moveos-config/src/store_config.rs | Defines three new RocksDB configuration fields with defaults |
| crates/rooch/src/utils.rs | Updates RocksDB initialization to pass configuration to column family options |
| crates/rooch/src/commands/db/commands/gc.rs | Adds marker strategy command-line option and conversion logic |
| crates/rooch-pruner/src/util.rs | Introduces extract_child_nodes function with comprehensive test coverage |
| crates/rooch-pruner/src/reachability.rs | Refactors to use new extract_child_nodes function, removing duplicated logic |
| crates/rooch-pruner/src/marker.rs | Defines MarkerStrategy enum with Display and serialization support, updates create_marker signature |
| crates/rooch-pruner/src/garbage_collector.rs | Implements marker auto-sizing with cap, strategy-based marker creation, and improved logging |
| crates/rooch-pruner/src/config.rs | Adds marker_strategy field to GC configuration with default |
| crates/rooch-pruner/Cargo.toml | Adds prometheus dependency for test utilities |
| crates/rooch-config/src/store_config.rs | Propagates new RocksDB fields through configuration builder |
| crates/rooch-benchmarks/benches/bench_gc.rs | Updates benchmark to use tuned batch size variable |
| Cargo.lock | Reflects prometheus dependency addition |
|
Docker images for this PR are available:
Pull commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR