Fix gc command and reorg pruner docs#3841
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions from runtime pruning to an offline GC approach and consolidates pruner documentation. The changes remove the complex runtime pruner daemon, simplify the marker strategy to use only Bloom filters, and provide clearer operational guidance.
Key changes:
- Removed runtime pruner infrastructure and replaced with offline GC command
- Unified marker strategy to
BloomFilterMarker(removedInMemoryMarkerandPersistentMarker) - Consolidated and reorganized documentation into
offline_gc_guide.mdand updatedpruner_guide.md - Auto-detection of
protected_roots_countbased on network type - Improved disk space detection for nested mount points in recycle bin
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
docs/dev-guide/statedb_prune.md |
Removed detailed design proposal (archived) |
docs/dev-guide/pruner_guide.md |
Rewritten to document archived runtime pruner with design rationale |
docs/dev-guide/pruner_e2e_testing_guide.md |
Removed E2E testing guide (consolidated elsewhere) |
docs/dev-guide/offline_gc_guide.md |
New comprehensive guide for stop-the-world Mark–Sweep GC |
moveos/moveos-types/src/prune.rs |
Removed unused pruner types module |
moveos/moveos-types/src/lib.rs |
Removed prune module export |
crates/rooch/src/commands/db/commands/gc.rs |
Added auto-detection for protected roots count based on network |
crates/rooch-pruner/src/marker.rs |
Simplified to single BloomFilterMarker strategy with optimal sizing |
crates/rooch-pruner/src/config.rs |
Removed marker strategy options and unused parameters |
crates/rooch-pruner/src/garbage_collector.rs |
Updated to use unified Bloom filter marker with improved node count estimation |
crates/rooch-pruner/src/recycle_bin.rs |
Improved disk detection to handle nested mount points correctly |
crates/rooch-pruner/tests/* |
Removed obsolete test files for deleted marker strategies |
.dockerignore |
Added comprehensive Docker ignore patterns |
|
Docker images for this PR are available:
Pull commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR