feat: Add resource limits to DID and Payment Channel modules#3796
Merged
Conversation
- Add limits for DID services (32 max), service properties (16 max), fragment length (128 bytes), string length (512 bytes) - Add proof count limits for Payment Channel close/cancel operations (64 max) - Implement validation functions and checks in all entry points - Add comprehensive tests for all limits including boundary cases - Fix inconsistency where property keys/values weren't validated against string limits - All existing functionality preserved with backward compatibility Tests: All new limit tests pass, existing tests pass Risk: Low - only adds validation, no breaking changes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements resource limits for DID and Payment Channel modules to prevent potential DoS attacks and ensure reasonable resource usage.
Changes
DID Module Limits
Payment Channel Limits
Key Features
Security Impact
Testing
Closes security review item from mainnet readiness checklist.