Add locked unit reserve for payment hub withdrawals#3792
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Add locked unit reserve for payment hub withdrawals
Add locked unit reserve for payment hub withdrawals
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a per-coin locked unit reserve mechanism that allows withdrawals from PaymentHub even when channels are active, provided sufficient unlocked balance remains.
Changes
PaymentHubConfigwith per-coinlocked_unit_per_cointablewithdraw_from_hubnow checksunlocked_balance = total_balance - (locked_unit × active_channel_count)instead of blocking all withdrawalsset_locked_unit<CoinType>configures reserve per coin type with monotonic non-decreasing enforcementLockedUnitConfigUpdatedEventtracks config changesget_unlocked_balance_in_hub,get_required_locked_for_owner,get_locked_unitcopyoperations and redundant wrapper functionsBehavior
Before: Any active channel blocks all withdrawals
After: Withdrawals allowed up to unlocked balance, maintaining
locked_unit × active_channelsreserveOverflow protection relies on Move's built-in abort; governance expected to set reasonable
locked_unitvalues.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.