Skip to content

fix docker build workflow#3776

Merged
jolestar merged 1 commit into
mainfrom
fix_docker_build
Nov 20, 2025
Merged

fix docker build workflow#3776
jolestar merged 1 commit into
mainfrom
fix_docker_build

Conversation

@jolestar

Copy link
Copy Markdown
Contributor

Summary

Summary about this PR

  • Closes #issue

@vercel

vercel Bot commented Nov 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rooch Building Building Preview Comment Nov 19, 2025 11:59pm
rooch-portal-v2.1 Building Building Preview Comment Nov 19, 2025 11:59pm
test-portal Ready Ready Preview Comment Nov 19, 2025 11:59pm

@jolestar jolestar requested a review from Copilot November 19, 2025 23:58
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes potential shell expansion issues in the Docker build workflow's label checking logic.

  • Changed test syntax from POSIX [ ] to bash [[ ]] for more robust string comparison
  • Fixed JSON handling by using single quotes instead of double quotes to prevent shell expansion of special characters

@jolestar jolestar merged commit a082163 into main Nov 20, 2025
23 of 25 checks passed
@jolestar jolestar deleted the fix_docker_build branch November 20, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants