[did] Support did:bitcoin as controller#3717
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends DID support to include did:bitcoin controllers alongside the existing did:key controllers in the CADOP (Custodian-Assisted DID Onboarding Protocol) framework.
Key Changes:
- Adds support for
did:bitcoincontroller validation in DID creation - Refactors existing CADOP functions to use a generic controller-based approach
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frameworks/rooch-framework/sources/did.move | Core implementation adding did:bitcoin controller support with validation logic and refactored CADOP functions |
| frameworks/rooch-framework/sources/tests/did_cadop_controller_test.move | New test module covering both success and failure scenarios for did:bitcoin controllers |
| frameworks/rooch-framework/doc/did.md | Updated documentation reflecting new functions and error constants |
| examples/verity_oracle_example/sources/example.move | Minor fix updating module reference from coin_store to account_coin_store |
| examples/verity_oracle_example/Move.toml | Added new test address for foreign module testing |
| custodian_service_vm_type, | ||
| custom_scope_strings, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Extra whitespace after closing brace on line 729. Remove the trailing space for consistency.
Suggested change
| } | |
| } |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Docker images for this PR are available:
Pull commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.