Implement payment revenue#3714
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a payment revenue management system that separates revenue earned through payment channels from principal funds. The implementation creates a dedicated revenue hub for tracking and managing revenue separately from regular payment hubs.
- Adds a new
payment_revenuemodule for managing revenue separately from principal funds - Integrates payment revenue tracking into existing payment channel operations
- Provides CLI commands for querying and withdrawing revenue
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frameworks/rooch-framework/sources/payment_revenue.move | New module implementing revenue management with hubs, deposit/withdrawal, and source tracking |
| frameworks/rooch-framework/sources/payment_channel.move | Updated to deposit payments as revenue instead of regular hub deposits |
| frameworks/rooch-framework/doc/payment_revenue.md | Auto-generated documentation for the new payment revenue module |
| frameworks/rooch-framework/doc/payment_channel.md | Updated documentation to reflect payment revenue integration |
| frameworks/rooch-framework/doc/README.md | Added payment_revenue module to documentation index |
| crates/testsuite/features/payment_channel.feature | Updated test scenarios to use revenue management instead of payment hubs |
| crates/rooch/src/commands/payment_channel/mod.rs | Added query-revenue and withdraw-revenue CLI commands |
| crates/rooch/src/commands/payment_channel/commands/withdraw_revenue.rs | New CLI command for withdrawing revenue |
| crates/rooch/src/commands/payment_channel/commands/query_revenue.rs | New CLI command for querying revenue balances |
| crates/rooch/src/commands/payment_channel/commands/mod.rs | Added new command module exports |
| crates/rooch/src/commands/payment_channel/commands/finalize_cancellation.rs | Updated to use DID-based transaction signing |
| crates/rooch/src/commands/payment_channel/commands/dispute.rs | Updated to use DID-based transaction signing |
| crates/rooch/src/commands/payment_channel/commands/close.rs | Updated to use DID-based transaction signing |
| crates/rooch-types/src/framework/payment_revenue.rs | Rust type bindings for the payment revenue module |
| crates/rooch-types/src/framework/mod.rs | Added payment_revenue module export |
|
Docker images for this PR are available:
Pull commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.