[Pruner] Enable pruner#3675
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Docker images for this PR are available:
Pull commands:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the pruner functionality in the Rooch blockchain testnet deployment and adds performance optimizations for bulk deletion operations during pruning.
- Enables the pruner by adding the
--pruner-enableflag to the testnet deployment script - Adds optimized bulk deletion methods with configurable flushing for better performance during pruning operations
- Implements WAL flush capabilities and periodic flushing to manage memory usage during large-scale deletions
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/deploy_rooch_testnet.sh | Enables pruner in testnet deployment by adding the --pruner-enable flag |
| moveos/raw-store/src/rocks/mod.rs | Adds inner DB access and WAL flush methods for advanced pruning operations |
| moveos/moveos-store/src/state_store/mod.rs | Implements optimized bulk deletion with configurable flushing and compaction methods |
| moveos/moveos-store/Cargo.toml | Adds rocksdb dependency for direct database operations |
| crates/rooch-rpc-server/src/lib.rs | Passes shutdown signal to pruner for graceful termination |
| crates/rooch-pruner/src/util.rs | Simplifies table detection logic using placeholder hash comparison |
| crates/rooch-pruner/src/tests/test_pruner.rs | Comments out assertions in test (likely due to changed behavior) |
| crates/rooch-pruner/src/sweep_expired.rs | Adds periodic flushing and improved logging for bulk deletion operations |
| crates/rooch-pruner/src/pruner.rs | Integrates shutdown signal handling and improves logging with state root information |
Comment on lines
+64
to
+65
| // for test | ||
| thread::sleep(Duration::from_secs(60)); |
There was a problem hiding this comment.
The hardcoded 60-second sleep with a "for test" comment should not be in production code. This appears to be temporary debugging code that should be removed before deployment.
Suggested change
| // for test | |
| thread::sleep(Duration::from_secs(60)); |
jolestar
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR