Fix ConfigurationBuilder addClassLoaders#288
Merged
ronmamo merged 2 commits intoronmamo:release/0913from Apr 26, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addClassLoaders(ClassLoader ... classloaders)was trying to concatenateClassLoader.classto the stream of classloaders, and thetoArray()method would fail given thatClassLoader.classis not of typeClassLoader.Notice that I could not understand why there is interest in adding the
ClassLoader.classso my solution was to remove it.If what we are seeking is that the class loader of the
ClassLoaderis to be added, then probably we are missing aClassLoader.class.getClassLoader(). But doing so would be inconsistent as the following would not produce same output:In the second case, the
ClassLoader.classwould be ignored, because theClassLoader[] classLoadersfield of theConfigurationBuilderis null and thenclassLoaderswould simply match the passed{ foo, bar }array.