Skip to content

feat(ui): add Escape key to dismiss menu bar popup#97

Merged
ronitsingh10 merged 1 commit intoronitsingh10:mainfrom
AbdulEmad:feature/esc-dismiss
Feb 21, 2026
Merged

feat(ui): add Escape key to dismiss menu bar popup#97
ronitsingh10 merged 1 commit intoronitsingh10:mainfrom
AbdulEmad:feature/esc-dismiss

Conversation

@AbdulEmad
Copy link

Summary

  • Adds ESC keyboard shortcut to dismiss the menu bar popup
  • Layered behavior: closes settings panel first, then collapses EQ panel, then dismisses the popup window
  • Follows the existing hidden-button pattern used for the ⌘, shortcut

Test plan

  • Open the popup and press ESC — popup should dismiss
  • Open Settings (⌘,), press ESC — settings should close, popup stays open
  • Expand an app's EQ panel, press ESC — EQ collapses, popup stays open

Adds layered Escape key handling: closes settings panel first,
then collapses EQ panel, then dismisses the popup window.
@ct1735x
Copy link

ct1735x commented Feb 21, 2026

Would love to see this merged!

@ronitsingh10 ronitsingh10 merged commit 95d5fff into ronitsingh10:main Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants