Skip to content

feat: add URL schemes#1

Merged
ronitsingh10 merged 4 commits intoronitsingh10:mainfrom
Boettner-eric:feature/url-schemes
Feb 4, 2026
Merged

feat: add URL schemes#1
ronitsingh10 merged 4 commits intoronitsingh10:mainfrom
Boettner-eric:feature/url-schemes

Conversation

@Boettner-eric
Copy link
Contributor

  • register finetune:// as a valid URL scheme
  • add paths for volume levels, muting, and device selection
  • no changes to AudioEngine

@Boettner-eric
Copy link
Contributor Author

Boettner-eric commented Jan 20, 2026

@ronitsingh10 I did experience some weird behavior when trying to set the volume with float values. If I set it to 1 or 2 it works properly but when I try a value like 0.5 it gets set to 89%. It's very likely I misunderstood the volume setting behavior so feel free to comment if there is a better way to set these.

Edit: I think VolumeMapping had the functions I was looking for.

@Boettner-eric Boettner-eric force-pushed the feature/url-schemes branch 2 times, most recently from cd5e89c to d0d8528 Compare January 27, 2026 21:59
@Boettner-eric
Copy link
Contributor Author

Ready for review!

  • Fixed issue with launch race condition
  • Tested on multiple devices / apps
  • Rebased and up to date

@ronitsingh10 ronitsingh10 merged commit 4c71a28 into ronitsingh10:main Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants