Fixes #511: Allow deserialize_string for map fields originating from struct-formatted maps#512
Merged
Merged
Conversation
… from struct-formatted maps
juntyr
reviewed
Oct 2, 2023
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 79 80 +1
Lines 11109 11178 +69
=========================================
+ Hits 11109 11178 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@grindvoll Thanks for the PR! It looks good to me once codecov is 100% and with the small CHANGELOG tweak. |
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
juntyr
reviewed
Oct 4, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an incoherence problem in the Deserializer implementation for fields in struct-encoded maps.
deserialize_strwas accepted, whiledeserialize_stringwas rejected. This behavior caused a problem when deserializing e.g.serde_json::Valuesfrom RON-files.CHANGELOG.md