Skip to content

Fix parsing of struct/variant names starting in None, Some, true, or false#499

Merged
juntyr merged 3 commits into
ron-rs:masterfrom
juntyr:implicit-some-consume-ident
Sep 5, 2023
Merged

Fix parsing of struct/variant names starting in None, Some, true, or false#499
juntyr merged 3 commits into
ron-rs:masterfrom
juntyr:implicit-some-consume-ident

Conversation

@juntyr

@juntyr juntyr commented Sep 5, 2023

Copy link
Copy Markdown
Member
  • I've included my change in CHANGELOG.md

@juntyr juntyr changed the title Fix consume_str for Some None Fix consume_str for Some and None Sep 5, 2023
@codecov-commenter

codecov-commenter commented Sep 5, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (10021d1) to head (b5655bf).
⚠️ Report is 59 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          78       78           
  Lines       10542    10592   +50     
=======================================
+ Hits        10479    10529   +50     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juntyr juntyr changed the title Fix consume_str for Some and None Fix parsing of struct/enum names starting in None or Some Sep 5, 2023
@juntyr juntyr force-pushed the implicit-some-consume-ident branch from d178efb to 19d5ab7 Compare September 5, 2023 07:28
@juntyr juntyr changed the title Fix parsing of struct/enum names starting in None or Some Fix parsing of struct/variant names starting in None or Some Sep 5, 2023
@juntyr juntyr changed the title Fix parsing of struct/variant names starting in None or Some Fix parsing of struct/variant names starting in None, Some, true, or false Sep 5, 2023
@juntyr juntyr merged commit 9ecb1e5 into ron-rs:master Sep 5, 2023
@juntyr juntyr deleted the implicit-some-consume-ident branch September 5, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants