Skip to content

Disallow unclosed line comments at the end of raw values#489

Merged
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:raw-unclosed-comment
Aug 26, 2023
Merged

Disallow unclosed line comments at the end of raw values#489
juntyr merged 1 commit into
ron-rs:masterfrom
juntyr:raw-unclosed-comment

Conversation

@juntyr

@juntyr juntyr commented Aug 26, 2023

Copy link
Copy Markdown
Member

Fixes fuzzer-found issue #61769, where an unclosed line comment at the end of a raw value can stop roundtripping since the line comment can comment out any following ron.

  • I've included my change in CHANGELOG.md

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Patch coverage: 89.36% and project coverage change: -0.03% ⚠️

Comparison is base (05b46c8) 95.33% compared to head (3cdd633) 95.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   95.33%   95.31%   -0.03%     
==========================================
  Files          74       74              
  Lines        8964     9000      +36     
==========================================
+ Hits         8546     8578      +32     
- Misses        418      422       +4     
Files Changed Coverage Δ
src/error.rs 42.23% <0.00%> (-0.69%) ⬇️
src/parse.rs 96.75% <93.75%> (+0.02%) ⬆️
src/de/mod.rs 96.58% <100.00%> (+0.01%) ⬆️
tests/407_raw_value.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr merged commit c65fa75 into ron-rs:master Aug 26, 2023
@juntyr juntyr deleted the raw-unclosed-comment branch August 26, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants