Codecov Report

Patch coverage: 100.00% and project coverage change: +2.01% 🎉

Comparison is base (f693d7e) 96.12% compared to head (b14096a) 98.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   96.12%   98.14%   +2.01%     
==========================================
  Files          77       78       +1     
  Lines        9890    10308     +418     
==========================================
+ Hits         9507    10117     +610     
+ Misses        383      191     -192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torkleyy I've finally gotten to rebasing #444. I would propose merging it after #438 lands - while I will try to find some performance improvements earlier, I think parsing in UTF8 cleans up the code so much that landing early and optimising in later commits could also be warranted.

The last commit, 93f367c, adds an API-breaking change to better encode that ron only produces valid UTF-8 during serialising (by switching from io::Write to fmt::Write). If we don't want the API breakage, we could also add our own trait that is implemented for String and anything that implements io::Write.

@ModProg @torkleyy This PR is now (almost) ready to be merged. I'll review the changes again tomorrow and add a CHANGELOG entry. Apart from that, I think this is a very good new implementation (thank you so much @ModProg for doing most of the work towards it), which can be improved performance-wise in follow-up PRs if necessary

@torkleyy We are also getting closer and closer to 100% code coverage ... maybe before releasing v0.9 that's the last thing after this PR that I take care of.