Improve code coverage CI with grcov HTML reports#483
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 74 74
Lines 9267 9268 +1
=======================================
+ Hits 7687 7688 +1
Misses 1580 1580 ☔ View full report in Codecov by Sentry. |
Member
Author
|
It seems this may be a codecov problem, see rust-lang/rust#102477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves our code coverage generation and moves our coverage data from codecov.io to self-hosting it on GitHub pages (
since the reports on codecov.io have very weird lines whereas grcov's HTML report is much betteredit: this was a mistake in the CI, which was mixing up non-coverage builds). On PRs, the HTML reports should now be accessible as artefacts, on pushes to the main branch, the coverage data is re-deployed.* [ ] I've included my change inCHANGELOG.md