Add minimal support for flattening roundtrips through maps#453
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 86.65% 86.56% -0.09%
==========================================
Files 60 61 +1
Lines 7364 7586 +222
==========================================
+ Hits 6381 6567 +186
- Misses 983 1019 +36
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
you could cherry-pick #454 here? |
|
Sure, just go ahead. |
Ok, I'll cherry pick your changes later today :) |
|
Superseded by #455 |
Alternative to #403 which adds minimal support for
#[serde(flatten)]to RON. Instead of many workarounds to make flattened structs serialise into nice RON struct syntax and deserialise from them, both of which are really difficult since serde gives us no information to work with and just delegates to map serialisation/deserialisation, this PR just ensures that at least flattened structs can roundtrip through RON.For this, just one hack is necessary. Map keys that request identifiers can now be deserialised from strings, sort of. But only if they are written exactly as
", identifier,". This seems to be enough to get the tests to work that I initially designed for #403.@torkleyy I'd be in favour of landing this instead of going down the rabbit hole of #403 since that just fixes one of the two parts and getting flattened structs to serialise correctly would require hacks of another order.
This would not really fix #115 but at least get some working if imperfect solution.
CHANGELOG.md