Fix #370 with better float EBNF and +inf -NaN +NaN parsing#371
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 89.52% 89.63% +0.10%
==========================================
Files 47 48 +1
Lines 5157 5219 +62
==========================================
+ Hits 4617 4678 +61
- Misses 540 541 +1
Continue to review full report at Codecov.
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370
Fixes the RON grammar for floats to be equivalent to
FromStr's grammar (which we use internally):Consequently, RON now also accepts
+inf,-NaN, and+NaN.In comparison with
rustc,FromStrstill accepts floats without a leading digit, e.g..3- these continue to work. The other way around,rustcaccepts underscores in floats whileFromStrand all other parsers I checked do not. I've added a special errorFloatUnderscoreto lint against this case.CHANGELOG.md