Fixed #367 with eager implicit some#368
Merged
Merged
Conversation
Member
Author
|
I will wait to merge this PR until tomorrow evening so I can have a fresh look then |
dbb1c04 to
8cb33d1
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 89.20% 89.52% +0.32%
==========================================
Files 46 47 +1
Lines 5056 5157 +101
==========================================
+ Hits 4510 4617 +107
+ Misses 546 540 -6 ☔ View full report in Codecov by Sentry. |
kvark
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #367 by moving the
implicit_someunwrap check after an eager check forSome(..)CHANGELOG.md