Enable decimal_floats by default for Value::Number(Float) roundtrip#363
Merged
Conversation
Member
Author
Closed
kvark
approved these changes
Feb 18, 2022
kvark
left a comment
Collaborator
There was a problem hiding this comment.
Does it even need to be an option?
I would think just removing the option entirely and doing this unconditionally would be better.
Member
Author
That's a good idea - thanks for the suggestion! This commit will of course require a version bump as it is a breaking change, though I guess the usefulness of not including a decimal was questionable from the start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdFixes #337