Skip to content

Remove version downgrades, bump msrv to 1.46.0#355

Closed
torkleyy wants to merge 3 commits into
ron-rs:masterfrom
torkleyy:msrv
Closed

Remove version downgrades, bump msrv to 1.46.0#355
torkleyy wants to merge 3 commits into
ron-rs:masterfrom
torkleyy:msrv

Conversation

@torkleyy

Copy link
Copy Markdown
Member
  • I've included my change in CHANGELOG.md

Fixes #347

@torkleyy torkleyy requested review from juntyr and kvark December 27, 2021 09:12
Comment thread Cargo.toml

@juntyr juntyr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also resolve the // TODO: use fXX::EPSILON when minimum supported rust version is 1.43 comments in this MSRV bump?

@enfipy

enfipy commented Jan 27, 2022

Copy link
Copy Markdown

We are also blocked by this. May we push this forward? ❤️

@juntyr

juntyr commented Jan 28, 2022

Copy link
Copy Markdown
Member

We are also blocked by this. May we push this forward? ❤️

@enfipy As @torkleyy seems to be busy at the moment, I'll update the PR and get it merged today.

@juntyr

juntyr commented Jan 28, 2022

Copy link
Copy Markdown
Member

Superseded by #361

@juntyr juntyr closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert #340

3 participants