Revert #329 and add to_string/writer_advanced functions instead#334
Revert #329 and add to_string/writer_advanced functions instead#334malte-v wants to merge 3 commits into
to_string/writer_advanced functions instead#334Conversation
to_string/writer_advanced functions instead
kvark
left a comment
There was a problem hiding this comment.
I trust your judgement on this. Personally I wasn't convinced by the argument in #329 (comment)
RON isn't self-describing, it relies on types, so forcing it to be distinctive for different types shouldn't be a goal.
|
Yeah, the argument in #329 (comment) doesn't that make much sense tbh. However, I still stand by the argument that the option to emit struct names does not belong in PrettyConfig because it makes a difference when deserializing, unlike the other options in PrettyConfig. |
|
Ok, that argument sounds more reasonable :) |
|
@MomoLangenstein I think this interacts with your PR #343, right? Any thoughts on how to incorporate both these PRs? |
Yes, it does! I think that this would be a fantastic option to add to the |
|
Sounds good to me! I'm wondering if we even need to expose any kind of |
That's a good point. Right now I feel like there shouldn't be more convenience functions. I like that when you just want to get RON running you only need |
|
I don't plan to take this any further, closing. |
See #329 (comment)
Unlike #329, this approach preserves backwards compatibility. I've also removed some duplicate code along the way.
CHANGELOG.md