Skip to content

[HOTFIX] Multi roms should only consider top-level files #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gantoine merged 2 commits into from
Dec 30, 2025
Merged

[HOTFIX] Multi roms should only consider top-level files #2821

gantoine merged 2 commits into from
Dec 30, 2025
+7 −3

Conversation

@gantoine
Copy link
Member

@gantoine gantoine commented Dec 30, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

ps1/
  - SSX.iso         # has_simple_single_file = True
  - FF Tactics/     # has_nested_single_file = True
    - FF Tactics.iso
  - Seaman/         # has_nested_single_file = True
    - Seaman.iso
    - hacks/
      - some_hack.zip
  - FF7/            # has_multiple_files = True
    - Disc 1.iso
    - Disc 2.iso
    - hacks/
      - some_hack.zip

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gantoine gantoine requested a review from zurdi15 December 30, 2025 21:42
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 30, 2025

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This hotfix addresses an inconsistency in how rom file structures are identified and presented, particularly for multi-file or nested single-file roms. The changes refine the backend's classification logic to focus solely on top-level files, ensuring that the frontend UI accurately reflects whether a rom should be referred to by its folder name or filename, thereby improving data integrity and user clarity.

Highlights

  • Backend Logic Refinement: The Rom model's properties, specifically has_nested_single_file and has_multiple_files, have been updated to exclusively consider top-level files when determining the structure and count of associated rom files. This ensures more accurate classification of rom types.
  • Frontend UI Alignment: The EditRom dialog in the frontend has been modified to align with the updated backend logic. It now correctly displays 'folder-name' for roms that are identified as having a nested single top-level file, providing a consistent user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with identifying multi-file ROMs by correctly considering only top-level files. The logic changes in backend/models/rom.py are sound and fix the described problem. I've included a suggestion to refactor the implementation for better performance and code reuse. The related frontend update in EditRom.vue is also correct, ensuring the UI label for the ROM's name field accurately reflects whether it's a file or a folder.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025 •
edited
Loading

Test Results

678 tests  ±0   677 ✅ ±0   1m 16s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 734645a. ± Comparison against base commit 7619b0b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11959 7728 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/models/rom.py 92% 🟢
TOTAL 92% 🟢

updated for commit: 734645a by action🐍

@gantoine
Copy link
Member Author

gantoine commented Dec 30, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a hotfix to correctly identify multi-file ROMs by considering only top-level files, ignoring nested ones like hacks or extras. The logic changes in backend/models/rom.py seem to correctly address the scenarios outlined in the description. The corresponding frontend update in EditRom.vue to adjust the label for directory-based ROMs is also appropriate. My main feedback is to add unit tests to verify this new logic and prevent future regressions.

@gantoine gantoine merged commit f2b164c into master Dec 30, 2025
9 checks passed
@gantoine gantoine deleted the fixup-has-multi-file branch December 30, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zurdi15 zurdi15 zurdi15 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gantoine @zurdi15