This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Add "resolve" option to createFilter#61
Merged
Merged
Conversation
This was referenced May 14, 2019
|
Can we have some tests against virtual modules? expect(filter('\0proxy-modules:x')).toBe...
expect(filter('\0proxy-modules:' + path.resolve('x'))).toBe... |
Member
Author
|
I allowed |
Member
Author
|
Ah, looking into your motivation, maybe I should also fix the names of proxy modules in rollup-plugin-commonjs... |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a new
resolveoption tocreateFilterto allow specifying a base directory other thanprocess.cwd()or disable resolution altogether.Resolves #39
Resolves #20
It is specified via an optional third parameter:
createFilter(includes, excludes, {resolve: '/my/base/dir'})Passing a string as
resolvewill resolve patterns like this:path.resolve(resolve, pattern)instead of just
path.resolve(pattern)Passing
falsewill disable this behaviour altogether and directly use the supplied pattern (which is useful if you want to match virtual directories as well).