This repository was archived by the owner on Aug 4, 2021. It is now read-only.
fix(scopes): Support Function and Class Declarations without id#28
Merged
lukastaegert merged 1 commit intorollup:masterfrom May 7, 2018
danez:fix/declarations
Merged
fix(scopes): Support Function and Class Declarations without id#28lukastaegert merged 1 commit intorollup:masterfrom danez:fix/declarations
lukastaegert merged 1 commit intorollup:masterfrom
danez:fix/declarations
Conversation
These declarations are used in combination with default exports
```
export default function () {};
```
Contributor
Author
|
@Rich-Harris I know pinging people directly is annoying, but I would really like to move forward with migrating babel-standalone to rollup and I'm blocked by this. So If you have a free minute I would really appreciate if you could review and if okay merge and release. |
guybedford
approved these changes
Apr 19, 2018
Contributor
guybedford
left a comment
There was a problem hiding this comment.
This looks good to me, will see if we can get this merged soon.
Member
|
Note that by |
Contributor
|
Just saw this — @lukastaegert, have added you and Guy as npm owners. Perhaps we should eventually consider moving some of these packages into a |
lukastaegert
approved these changes
Apr 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declarations without id are used in combination with default exports
http://astexplorer.net/#/gist/cf7df7dd64907912d4c0b0c270c4d42c/39593db1b7ae5b05649f7d524e78f7439359602c
Without the fix I receive:
//cc @Rich-Harris, @rollup :)