Skip to content

Return null to defer to the default resolution behavior#6084

Merged
lukastaegert merged 1 commit intomasterfrom
fix/6083
Aug 31, 2025
Merged

Return null to defer to the default resolution behavior#6084
lukastaegert merged 1 commit intomasterfrom
fix/6083

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6083

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Aug 28, 2025 0:58am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6083

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-aqha39hit-rollup-js.vercel.app/repl/?pr=6084

@github-actions
Copy link
Copy Markdown

Performance report

  • BUILD: 7021ms, 824 MB
    • initialize: 0ms, 24.8 MB
    • generate module graph: 2628ms, 631 MB
      • generate ast: 1373ms, 621 MB
    • sort and bind modules: 401ms, 688 MB
    • mark included statements: 3984ms, 824 MB
      • treeshaking pass 1: 2350ms, 821 MB
      • treeshaking pass 2: 463ms, 836 MB
      • treeshaking pass 3: 396ms, 825 MB
      • treeshaking pass 4: 385ms, 830 MB
      • treeshaking pass 5: 380ms, 824 MB
  • GENERATE: 894ms, 922 MB
    • initialize render: 0ms, 876 MB
    • generate chunks: 137ms (+54ms, +65.3%), 837 MB (-4%)
      • optimize chunks: 0ms, 824 MB (-4%)
    • render chunks: 723ms (-15ms, -2.1%), 896 MB
    • transform chunks: 18ms, 922 MB
    • generate bundle: 0ms, 922 MB

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (b12c061) to head (18c4d72).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6084   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         271      271           
  Lines       10622    10622           
  Branches     2840     2840           
=======================================
  Hits        10494    10494           
  Misses         88       88           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@lukastaegert lukastaegert added this pull request to the merge queue Aug 31, 2025
Merged via the queue into master with commit bd02778 Aug 31, 2025
44 checks passed
@lukastaegert lukastaegert deleted the fix/6083 branch August 31, 2025 05:19
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.50.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensionless imports in rollup.config.js with --bundleConfigAsCjs stopped working in 4.49.0.

2 participants