Revert CustomPluginOptions to be an interface#5850
Merged
lukastaegert merged 2 commits intorollup:masterfrom Feb 24, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5850 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 269 269
Lines 8545 8545
Branches 1467 1467
=======================================
Hits 8421 8421
Misses 92 92
Partials 32 32 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Feb 24, 2025
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Interesting that this makes a difference, but sure.
|
This PR has been released as part of rollup@4.34.9. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
#5591 changed
CustomPluginOptionstype to be an Record, but that made it impossible to extend this type by declaration merging.This PR reverts that change.