Skip to content

feat: add support for LoongArch#5749

Merged
lukastaegert merged 1 commit intorollup:masterfrom
darkyzhou:master
Dec 6, 2024
Merged

feat: add support for LoongArch#5749
lukastaegert merged 1 commit intorollup:masterfrom
darkyzhou:master

Conversation

@darkyzhou
Copy link
Copy Markdown
Contributor

@darkyzhou darkyzhou commented Dec 1, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR adds support for LoongArch, a RISC-style ISA developed by Loongson.

Note: I am using build image from https://github.com/darkyzhou/napi-rs-nodejs-rust, which is based on unreleased Debian Trixie because the ecosystem of LoongArch is quite immature now.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 8:09am

@darkyzhou darkyzhou changed the title feat: add support for loongarch feat: add support for LoongArch Dec 1, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (0595e43) to head (6315215).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5749   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         258      258           
  Lines        8072     8072           
  Branches     1361     1361           
=======================================
  Hits         7992     7992           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As CI is happy, I will merge and release this now. Feel free to make follow-up PRs if things do not work as intended.

@lukastaegert lukastaegert added this pull request to the merge queue Dec 6, 2024
Merged via the queue into rollup:master with commit 4d6b077 Dec 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2024

This PR has been released as part of rollup@4.28.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants